reorder event loop timeouts so that playback status detector is faster than incoming notes

engine/api.py

@@ -148,9 +148,9 @@ midiInput = None #set in startEngine
 def startEngine(nsmClient):
     logger.info("Starting main programs api engine")
 
-    callbacks.playbackStatusChanged.append(finalizeRecording)
-
     callbacks.playbackStatusChanged.append(toggleUndoRecordingCollector)
+    callbacks.playbackStatusChanged.append(finalizeRecording) #this order means that finalizing happens always after toggleUndoRecordingCollector, which MUST be.
+
     callbacks.recordingModeChanged.append(checkIfPlaybackIsRunningWhileRecordinChanged)
 
     _templateStartEngine(nsmClient)
@@ -543,13 +543,13 @@ def toggleUndoRecordingCollector(state:bool):
         if session.data.eventCollectorForUndo is None:
             session.data.eventCollectorForUndo = []
 
+
 def checkIfPlaybackIsRunningWhileRecordinChanged(state:bool):
     """Called by the template api.
     Works in tandem with toggleUndoRecordingCollector because the user
     can toggle recording while playback is already/still running.
     """
-    pb = playbackStatus()
-    if state and pb: #recording was switch on during playback running
+    if state: #recording was switch on during playback running
         if session.data.eventCollectorForUndo is None:
             session.data.eventCollectorForUndo = []
 

engine/main.py

@@ -64,7 +64,7 @@ class Data(template.engine.sequencer.Score):
         #However, explicit is better than implicit.
         self.noteOnsInProgress = {i:set() for i in range(10)}
         self.track.sequencerInterface.insertEmptyClip() #needed for recording. Creates a maximum length empty clip
-        self.eventCollectorForUndo = [] #The api switches this between a list and None. Starting in a list enables to record right from the program start
+        self.eventCollectorForUndo = None #The api switches this between a list and None. Starting in a list enables to record right from the program start
         logger.info("Main Data instance complete")
         self.copyBuffer = []
 
@@ -105,34 +105,32 @@ class Data(template.engine.sequencer.Score):
 
 
     def livePolyphonicAftertouch(self, tickindex:int, note:int, value:int):
-         """0xA0 Connected via the api, which sends further callbacks to the GUI"""
-         if self.parentSession.recordingEnabled and not tickindex is None:
+        """0xA0 Connected via the api, which sends further callbacks to the GUI"""
+        if self.parentSession.recordingEnabled and not tickindex is None:
             assert not self.eventCollectorForUndo is None
             resultEvent = self.track.layers[self.track.activeLayer].newEvent(tickindex, 0xA0, note, value, "")
             self.eventCollectorForUndo.append(resultEvent)
             return resultEvent
 
     def liveCC(self, tickindex:int, type:int, value:int):
-         """0xB0 Connected via the api, which sends further callbacks to the GUI"""
-         if self.parentSession.recordingEnabled and not tickindex is None:
+        """0xB0 Connected via the api, which sends further callbacks to the GUI"""
+        if self.parentSession.recordingEnabled and not tickindex is None:
             assert not self.eventCollectorForUndo is None
             resultEvent = self.track.layers[self.track.activeLayer].newEvent(tickindex, 0xB0, type, value, "")
             self.eventCollectorForUndo.append(resultEvent)
             return resultEvent
 
-
-
     def liveProgramChange(self, tickindex:int, value:int):
-         """Connected via the api, which sends further callbacks to the GUI"""
-         if self.parentSession.recordingEnabled and not tickindex is None:
+        """Connected via the api, which sends further callbacks to the GUI"""
+        if self.parentSession.recordingEnabled and not tickindex is None:
             assert not self.eventCollectorForUndo is None
             resultEvent = self.track.layers[self.track.activeLayer].newEvent(tickindex, 0xC0, value, 0, "") #Byte2 gets ignored
             self.eventCollectorForUndo.append(resultEvent)
             return resultEvent
 
     def liveChannelPressure(self, tickindex:int, value:int):
-         """Connected via the api, which sends further callbacks to the GUI"""
-         if self.parentSession.recordingEnabled and not tickindex is None:
+        """Connected via the api, which sends further callbacks to the GUI"""
+        if self.parentSession.recordingEnabled and not tickindex is None:
             assert not self.eventCollectorForUndo is None
             resultEvent = self.track.layers[self.track.activeLayer].newEvent(tickindex, 0xD0, value, 0, "") #Byte2 gets ignored
             self.eventCollectorForUndo.append(resultEvent)

template/engine/api.py

@@ -295,9 +295,9 @@ def startEngine(nsmClient):
     assert callbacks
 
     session.nsmClient = nsmClient
+    session.eventLoop.directConnect(callbacks._checkPlaybackStatusAndSendSignal)
     session.eventLoop.fastConnect(callbacks._setPlaybackTicks)
     session.eventLoop.fastConnect(cbox.get_new_events) #global cbox.get_new_events does not eat dynamic midi port events.
-    session.eventLoop.slowConnect(callbacks._checkPlaybackStatusAndSendSignal)
     session.eventLoop.slowConnect(callbacks._checkBBTAndSendSignal)
     #session.eventLoop.slowConnect(lambda: print(cbox.Transport.status().tempo))
     #asession.eventLoop.slowConnect(lambda: print(cbox.Transport.status()))

template/qtgui/mainwindow.py

@@ -53,7 +53,10 @@ class EventLoop(object):
     def __init__(self):
         """The loop for all things GUI and controlling the GUI (e.g. by a control midi in port)
 
-        By default use fastConnect.
+        directConnect is 0ms (see below)
+        fastConnect 20ms
+        slowConnect 100ms
+        verySlowConnect 200ms
 
         0 ms means "if there is time". 10ms-20ms is smooth. 100ms is still ok.
         Influences everything. Control Midi In Latency, playback cursor scrolling smoothnes etc.
@@ -69,10 +72,14 @@ class EventLoop(object):
         We init the event loop outside of main but call start from the mainWindow.
         """
 
+        self.directLoop = QtCore.QTimer()
         self.fastLoop = QtCore.QTimer()
         self.slowLoop = QtCore.QTimer()
         self.verySlowLoop = QtCore.QTimer()
 
+    def directConnect(self, function):
+        self.directLoop.timeout.connect(function)
+
     def fastConnect(self, function):
         self.fastLoop.timeout.connect(function)
 
@@ -97,6 +104,8 @@ class EventLoop(object):
 
     def start(self):
         """The event loop MUST be started after the Qt Application instance creation"""
+        logger.info("Starting direct qt event loop")
+        self.directLoop.start(0)
         logger.info("Starting fast qt event loop")
         self.fastLoop.start(20)
         logger.info("Starting slow qt event loop")
@@ -105,6 +114,8 @@ class EventLoop(object):
         self.verySlowLoop.start(200)
 
     def stop(self):
+        logger.info("Stopping direct qt event loop")
+        self.directLoop.stop()
         logger.info("Stopping fast qt event loop")
         self.fastLoop.stop()
         logger.info("Stopping slow qt event loop")
@@ -143,9 +154,9 @@ class MainWindow(QtWidgets.QMainWindow):
         super().__init__()
         self.qtApp = qtApp
         self.qtApp.setWindowIcon(QtGui.QIcon(":icon.png")) #non-template part of the program
-        QtGui.QIcon.setThemeName("hicolor") #audio applications can be found here. We have no need for other  icons.        
+        QtGui.QIcon.setThemeName("hicolor") #audio applications can be found here. We have no need for other  icons.
         logger.info("Init MainWindow")
-        
+
         #Callbacks. Must be registered before startEngine.
         api.callbacks.message.append(self.callback_message)
 
@@ -172,9 +183,9 @@ class MainWindow(QtWidgets.QMainWindow):
         self.setWindowTitle(self.nsmClient.ourClientNameUnderNSM)
         self.qtApp.setApplicationName(self.nsmClient.ourClientNameUnderNSM)
         self.qtApp.setApplicationDisplayName(self.nsmClient.ourClientNameUnderNSM)
-        self.qtApp.setOrganizationName("Laborejo Software Suite")        
-        self.qtApp.setOrganizationDomain("laborejo.org")        
-        self.qtApp.setApplicationVersion(METADATA["version"])        
+        self.qtApp.setOrganizationName("Laborejo Software Suite")
+        self.qtApp.setOrganizationDomain("laborejo.org")
+        self.qtApp.setApplicationVersion(METADATA["version"])
         self.setAcceptDrops(True)
 
         self.debugScriptRunner = DebugScriptRunner(apilocals=locals()) #needs to have trueInit called after the session and nsm was set up. Which happens in startEngine.